zardus / ctf-tools

Some setup scripts for security research tools.
BSD 3-Clause "New" or "Revised" License
8.49k stars 1.89k forks source link

Fix manage-tools bug #138

Closed calee0219 closed 7 years ago

calee0219 commented 7 years ago

I can't install on my macOS with fish shell, and after this change, I can install it.

zardus commented 7 years ago

This would change the operation of this code on Ubuntu, unfortunately. ;& is a pass-through from the Ubuntu to the Debian case, but your fix would change the Ubuntu case to a no-op. Of course, on MacOS, that's not noticed.

I think the underlying problem is that your bash version is probably too old. Aside from this, you should be aware that it's very likely that many of these tools will not work on MacOS (and definitely most of the install scripts make Linux-specific assumptions).

calee0219 commented 7 years ago

Oh, I see. Thanks a lot~ <3