search

zardus / ctf-tools

Some setup scripts for security research tools.
BSD 3-Clause "New" or "Revised" License
8.38k stars 1.88k forks source link

"full-upgrade" to upgrade only installed tools #152

Closed f0rki closed 6 years ago

f0rki commented 6 years ago

just a quick thing I whipped up.

Maybe this is better suited as manage-tools upgrade all?

Fixes #7

zardus commented 6 years ago

I do like manage-tools upgrade all-installed or something better, yeah... We could handle it the same way we handle all and make it general for other actions as well (though it makes the most sense for upgrade).

That being said, I'm not super picky on this. If you don't have time to do it that way, we can go with this method here.

f0rki commented 6 years ago

I will do it next week.

On December 1, 2017 10:27:05 PM GMT+01:00, Yan notifications@github.com wrote:

I do like manage-tools upgrade all-installed or something better, yeah... We could handle it the same way we handle all and make it general for other actions as well (though it makes the most sense for upgrade).

That being said, I'm not super picky on this. If you don't have time to do it that way, we can go with this method here.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/zardus/ctf-tools/pull/152#issuecomment-348618623

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

f0rki commented 6 years ago

what do you think of simply manage-tools upgrade additionally to manage-tools upgrade all?

I think upgrade all-installed is too cumbersome to type. upgrade makes only sense on already installed tools anyway.

zardus commented 6 years ago

Sounds good!

On Mon, Dec 4, 2017 at 8:24 AM Michael Rodler notifications@github.com wrote:

what do you think of simply manage-tools upgrade additionally to manage-tools upgrade all?

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/zardus/ctf-tools/pull/152#issuecomment-348994505, or mute the thread https://github.com/notifications/unsubscribe-auth/ADSzl1f7kUwcU0WdqqFsSoHhebKxpAJ3ks5s9A6RgaJpZM4Qs80g .

f0rki commented 6 years ago

Sorry it took so long. It should be nicer to use now. You can do

manage-tools upgrade

or

manage-tools upgrade all

to upgrade all installed tools. Similarly the bin and reinstall commands also work only on the tools already installed.

I also added a function verify_tool_sanity, which checks whether the current TOOL variable is actually a directory in the ctf-tools repo, is not empty and not "all" (because it's handled somewhere else in the code).

zardus commented 6 years ago

Looks good!