search

zardus / ctf-tools

Some setup scripts for security research tools.
BSD 3-Clause "New" or "Revised" License
8.49k stars 1.89k forks source link

Add libheap GDB library #85

Closed ret2libc closed 8 years ago

ret2libc commented 8 years ago

I needed to build GDB with the python from the ctftools virtualenv, otherwise the libheap is not available... Is it a problem?

Also, travis is failing on my tests, but I think it's still because of pyvmmonitor's link that is not reliable at all :(

zardus commented 8 years ago

I actually like it better that way -- easier to install python plugins for it (such as in this case).

Would you mind checking if peda and gef still work after this change? If so, I'm all for it!

ret2libc commented 8 years ago

Peda works... I can't really test gef because GDB segfaults when I try to load it, but i think it's a problem in gdb/gef more than their installations

zardus commented 8 years ago

Sweet. Just to be sure, let's ping @f0rki. He added the gef support (and, now that I think about it, the pwndbg support), and I'd hate for him to be mad at us for breaking it :-)

Unless f0rki points out some fundamental issue with the gdb stuff related to this change, I'll merge it in soon. Thanks for the contribution!

f0rki commented 8 years ago

It really is far nicer this way :) pwndbg install is currently broken anyway because it needs python dependencies, which are searched in the system python paths. This way we can just install them in the virtualenv.

I have some notes on the libheap/install script though. This should suffice:

ctf-tools-pip install 'git+https://github.com/cloudburst/libheap'

or this if we want to keep things hackable in source

git clone --depth 1 https://github.com/cloudburst/libheap
ctf-tools-pip install -e libheap

Also instead of sourcing virtualenvwrapper and using workon, I think we should stick to ctf-tools-venv-activate . Am I correct to assume that @zardus ?

ret2libc commented 8 years ago

Yeah it's probably better to use ctf-tools-venv-activate. I didn't know about it because it's a recent (nice) addition ;)

zardus commented 8 years ago

Yep, I agree on all counts. I'll go ahead and fix it up after merging; I have a few minutes of free time and want to play around with libheap ;-)

ret2libc commented 8 years ago

Ops, thanks a lot!

zardus commented 8 years ago

I just pushed the changes we discussed!

Thank you for the contribution :-)