zarf-dev / zarf

DevSecOps for Air Gap & Limited-Connection Systems. https://zarf.dev/
Apache License 2.0
1.4k stars 171 forks source link

refactor: remove connect strings from packager property #2941

Closed phillebaba closed 2 months ago

phillebaba commented 2 months ago

Description

This change moves the connect strings map to the installed charts struct. This removes potential race conditions that could be caused by multiple threads writing to the same struct property.

Related Issue

Depends on #2940 Relates to #2576

Checklist before merging

netlify[bot] commented 2 months ago

Deploy Preview for zarf-docs canceled.

Name Link
Latest commit cebae127a3999a8348553c8e5fbc75644644949b
Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/66d15d2aee63d80008f7a02e
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pkg/packager/deploy.go 0.00% 16 Missing :warning:
src/pkg/cluster/zarf.go 0.00% 8 Missing :warning:
Files with missing lines Coverage Δ
src/pkg/packager/common.go 53.06% <ø> (ø)
src/pkg/packager/dev.go 0.00% <ø> (ø)
src/types/k8s.go 66.66% <ø> (ø)
src/pkg/cluster/zarf.go 19.26% <0.00%> (-0.46%) :arrow_down:
src/pkg/packager/deploy.go 5.86% <0.00%> (-0.02%) :arrow_down: