zarf-dev / zarf

DevSecOps for Air Gap & Limited-Connection Systems. https://zarf.dev/
Apache License 2.0
1.4k stars 171 forks source link

feat: switch to health checks for init package waits #2964

Closed AustinAbro321 closed 1 month ago

AustinAbro321 commented 1 month ago

Description

By using health checks we can ensure that resources are fully reconciled before continuing to the next component. This is especially important for the registry component. Since the registry is a re-deploy of the same helm chart as the seed-registry the deployment is already available with extra pods and the current wait condition passes immediately.

Related Issue

Fixes #2855

Checklist before merging

netlify[bot] commented 1 month ago

Deploy Preview for zarf-docs canceled.

Name Link
Latest commit 5b16e9482ad485dead8d1ccec0c6dbe6bfc2dfb4
Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/66d8ad55a197300008ea3350
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pkg/cluster/tunnel.go 0.00% 12 Missing :warning:
Files with missing lines Coverage Δ
src/pkg/cluster/tunnel.go 11.35% <0.00%> (-0.48%) :arrow_down:
AustinAbro321 commented 1 month ago

Closing this as #3043 is going to add this functionality to all deployments by default