zarf-dev / zarf

DevSecOps for Air Gap & Limited-Connection Systems. https://zarf.dev/
Apache License 2.0
1.42k stars 171 forks source link

feat: render tables on stdout #3226

Open mkcp opened 2 weeks ago

mkcp commented 2 weeks ago

Description

This PR introduces a TableWithWriter function, changes Table prints to use stdout, and changes common.ColorPrintYaml to use stdout.

Related Issue

Finishes #3223 Relates to #2576

Checklist before merging

netlify[bot] commented 2 weeks ago

Deploy Preview for zarf-docs canceled.

Name Link
Latest commit 36ab5632232ff28d87304b6bd009763716891b14
Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/673fb2946a616100082e8d9f
codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pkg/message/message.go 0.00% 7 Missing :warning:
src/pkg/utils/yaml.go 0.00% 2 Missing :warning:
src/cmd/common/table.go 0.00% 1 Missing :warning:
src/cmd/package.go 0.00% 1 Missing :warning:
src/pkg/message/connect.go 0.00% 1 Missing :warning:
src/pkg/message/credentials.go 0.00% 1 Missing :warning:
Files with missing lines Coverage Δ
src/cmd/connect.go 0.00% <ø> (ø)
src/cmd/dev.go 0.00% <ø> (ø)
src/cmd/root.go 0.00% <ø> (ø)
src/cmd/common/table.go 0.00% <0.00%> (ø)
src/cmd/package.go 0.00% <0.00%> (ø)
src/pkg/message/connect.go 0.00% <0.00%> (ø)
src/pkg/message/credentials.go 0.00% <0.00%> (ø)
src/pkg/utils/yaml.go 0.00% <0.00%> (ø)
src/pkg/message/message.go 11.32% <0.00%> (-0.45%) :arrow_down:

🚨 Try these New Features:

mkcp commented 1 week ago

Hold off on review or merge, I need to look over the failing e2e tests.

mkcp commented 6 days ago

reworking this approach, we shouldn't have to update globals

mkcp commented 4 days ago

Much better now - just chasing down failing tests.