feat: add logger to packager.Publish

zarf-dev / zarf

DevSecOps for Air Gap & Limited-Connection Systems. https://zarf.dev/

Apache License 2.0

1.42k stars 171 forks source link

feat: add logger to packager.Publish #3259

Closed mkcp closed 4 days ago

mkcp commented 5 days ago

Description

This one ended up being really simple because most of the downstream code had already been ported to slog. I started updating the tests to use the new logging, but decided that it's better if we wait until we swap over to the default format. Added a couple review comments for discussion.

Related Issue

Relates to #2576

Checklist before merging

[x] Test, docs, adr added or updated as needed
[x] Contributor Guide Steps followed

netlify[bot] commented 5 days ago

Deploy Preview for zarf-docs canceled.

Name	Link
Latest commit	daeb177b821c3ed8addd7275998abc2ad3b8be25
Latest deploy log	https://app.netlify.com/sites/zarf-docs/deploys/673f5f61cee3240008486266

codecov[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/pkg/packager/publish.go	0.00%	9 Missing :warning:

Files with missing lines	Coverage Δ
src/pkg/packager/publish.go	`0.00% <0.00%> (ø)`

... and 3 files with indirect coverage changes

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles