search

zargony / atom-language-rust

Rust language support in Atom - LOOKING FOR MAINTAINER, see #144
MIT License
116 stars 33 forks source link

Avoid using the ambiguous \h shorthand character #110

Closed pchaigno closed 7 years ago

pchaigno commented 7 years ago

Depending on the regular expression engine used, \h does not always mean the same. With a PCRE engine, it matches white spaces, whereas, with a Oniguruma engine, it matches hexademical digit characters. Atom uses an Oniguruma engine, but github.com relies on a PCRE engine.

zargony commented 7 years ago

Feels like a good idea to be compatible with pcre as well.

Btw, does Github use this grammar for Rust highlighting or why did you just mention Github?

CI fails for some unrelated reason I guess. I'll trigger a retry later

pchaigno commented 7 years ago

Yes, GitHub uses this grammar for Rust highlighting. See the Linguist repository for the list of grammars used.

zargony commented 7 years ago

Cool, I didn't know that :)

CI does work again after some adjustments to .travis.yml