search

zargony / atom-language-rust

Rust language support in Atom - LOOKING FOR MAINTAINER, see #144
MIT License
116 stars 33 forks source link

Need a hand? #119

Open mehcode opened 6 years ago

mehcode commented 6 years ago

@zargony

I'm working on ide-rust in conjunction with the Atom IDE and Rust Dev Tools movements.

I have some pain points with language-rust and I was taking a look but it seems like at least one of them ( #82 ) has an open PR.

I'd love to help you with adding syntax and improvements to the grammar here. Thoughts?

zargony commented 6 years ago

Any help would be much appreciated. Unfortunately I currently don't find much time to spend on improving language-rust. Most open issues are "complicated", i.e. they're not simple grammar rules problems but need a deeper look into how atom packages work (which I unfortunately don't have). If you'd like to stay for a while and help to move things ahead, I could as well add you as a collaborator. We should just make sure to discuss bigger changes openly first and to have working specs all time to prevent regressions.

82 looks nice, but is missing some automated specs. It adds some lines to test.rs which was used for manually reviewing syntax highlighting before we had specs.

jens1o commented 5 years ago

Any help would be much appreciated. Unfortunately I currently don't find much time to spend on improving language-rust. Most open issues are "complicated", i.e. they're not simple grammar rules problems but need a deeper look into how atom packages work (which I unfortunately don't have).

Is this still the case @zargony ?

zargony commented 5 years ago

Yes. I think I know Rust pretty well, but my knowledge of Atom’s JS internals is limited and RL keeps me busy, so I appreciate any help.

mehcode commented 5 years ago

ide-rust directly depends on this and @alexheretic now (and for quite some time) maintains it so he might have time and interest to help here

jens1o commented 5 years ago

That would be great, to further improve this project! :)

alexheretic commented 5 years ago

Yes I, and all atom rust users, am interested in improvements (though overall it's still working pretty well). However, I don't have a lot of free time myself at the moment.

Interestingly it looks like they'll also be official rust support for atom when they adopt the tree-sitter parsing system: https://github.com/atom/language-rust. But who knows when that'll be.

alexheretic commented 5 years ago

fyi https://github.com/atom/atom/pull/18257

zargony commented 5 years ago

Thanks. Looks like there’s a tree-sitter based grammar for Rust now.