search

zarillion / handynotes-plugins

A collection of HandyNotes plugins for World of Warcraft.
Other
46 stars 34 forks source link

Dragonflight: Elianna and Talisa Whisperbloom (in ED) nodes overlap Central Encampment icon #381

Closed Protuhj closed 10 months ago

Protuhj commented 10 months ago

ADDON VERSION: v43

Describe the bug When trying to mouseover the Elianna or Talisa Whisperbloom icons, you have to be real precise to not mouse over the Cental Encampment icon instead.

Ioney commented 10 months ago

i'm not sure, but i don't think we can force the frame strata of the node icons. it's probably set by HandyNotes.

zarillion commented 10 months ago

It is possible, but not directly through the interface HandyNotes provides. You have to re-assign the strata manually for those specific nodes using hooks. There was an example in the prepatch for Dragonflight:

https://github.com/zarillion/handynotes-plugins/blob/0778b0a6cf68db63ef6f54e2ea97a95f7037b494/plugins/09_Shadowlands/zones/prepatch.lua#L150-L160

Basically you add a custom hook for all HandyNotes pins, find a way to filter down to the pins you want (in this case, we used the texture) and then modify those pins.

Protuhj commented 10 months ago

If the nodes were offset, or displayed otherwise, that would be sufficient.

If the strata can solve the problem too, that would be ideal of course.

hollo6 commented 10 months ago

I came here to suggest moving Elianna's icon a bit further away from the center, that way it would also be more easily identifiable and more visible that there actually is an icon for the NPC.

Protuhj commented 10 months ago

This seems to be fixed in 44 -- @Ioney or @zarillion if you can confirm this was fixed, then the issue can be closed.

Edit: on second look, it seems like it just depends if I scale the icons up then it "appears" to be fixed, but then the icons overlap. Sorry for the ping.

Protuhj commented 10 months ago

I'm going to close this in favor of a different issue, because these nodes should probably be moved.