Closed pepedressingroom closed 7 months ago
WORLD_QUEST_REWARD_FILTERS_TITLE is a global string which caused the lint errors.
you have to change it to _G.WORLD_QUEST_REWARD_FILTERS_TITLE
and _G.LOOT
. this should fix the lint error.
Thank you @Ioney , But #https://github.com/zarillion/handynotes-plugins/pull/387/commits/9d31cb9853d395af1969813f40aff19c50871fba makes the vignettes of elemental storms do not show rewards correctly.
I think it's because the reward amount is different for each storm type.
@wyldclaw, any idea how to make this work?
im not at home right now so i cant test it ingame, but maybe this helps with displaying the rewards.
im not at home right now so i cant test it ingame, but maybe this helps with displaying the rewards.
@Ioney Yes, It works now! Thank you.
@pepedressingroom You have conflicts with master branch. This is because you need add the new commits done in master branch to your brach.
Regards
@pepedressingroom You have conflicts with master branch. This is because you need add the new commits done in master branch to your brach.
Regards
@Krovikan I have the recent changes pulled in, and solved the conflicts. Thank you.
Sorry @Ioney , it seems that the sand storm do not display rewards correctly. Just some of the storms work well, and the others don't. So that I moved TRANSMOG_REWARDS afterwards MANUSCRIPT_REWARDS.
Please help review this request
By the way, is there any one can tell me how to return a NPC name by its NPC id please?
Reference:
Budding Dreamtrove (Super Bloom)
Dragon Racer's Purse
Reach Racer's Purse
Cavern Racer's Purse
Dream Racer's Purse