Closed pepedressingroom closed 1 month ago
just paste the link to the commit like so : https://github.com/zarillion/handynotes-plugins/pull/389/commits/f1b76a3e1fb83d350e1c5a846f16b0f5e79488fb
https://github.com/zarillion/handynotes-plugins/pull/389/commits/f1b76a3e1fb83d350e1c5a846f16b0f5e79488fb
just paste the link to the commit like so :
https://github.com/zarillion/handynotes-plugins/pull/389/commits/f1b76a3e1fb83d350e1c5a846f16b0f5e79488fb
f1b76a3
Thank you @Ioney
@pepedressingroom You have a mistake in all locales and in Azure_span.lua
L["altar_of_decay_label"]
must be L['altar_of_decay_label']
.
Regards
L["altar_of_decay_label"]
must beL['altar_of_decay_label']
Thank you @Krovikan
@pepedressingroom L['khadin_prof_note'] = 'Gana %d more {currency:%d}s to max out {spell:%d} profession tree.'
You can show me a sentence did it with %d replaced? Can be of any profession, only for translate accurate.
Regards
@pepedressingroom L['khadin_prof_note'] = 'Gana %d more {currency:%d}s to max out {spell:%d} profession tree.'
You can show me a sentence did it with %d replaced? Can be of any profession, only for translate accurate.
Regards
@Krovikan I list how many currencies to max out tree nodes of the 2 professions for a player to decide either one to exchange Dragon Shards. My English is not good, and do you think the sentences make sense?
Regards.
Looks like some globals need to be added to .luacheckrc
still for the build to pass. I'm going to wait on merging these for now.
@pepedressingroom Is there anything else you want to add to this PR?
- Add World Boss Aurostor rewards (Is it possible to add extra tooltips such as rewards or achievements to world quests just like rare vignette?)
should be possible, i think we just need the quest id and add another hook function
@loney
I've been AFK for round half a year, since the returning news of the china server. Due to my lacking of experience, this PR looks like a great mess. Maybe I should not add too many things in one PR, and please help look after this PR.
I still have some thought and data to add in Dragonflight, but it will take me some time to sort.
@pepedressingroom you did a lot of commits since your last comment, are you still working on something or can i merge this PR?
@Ioney This PR seems ready to be merged now. Thank you for your guys help.
Fixes
Additions