zarillion / handynotes-plugins

A collection of HandyNotes plugins for World of Warcraft.
Other
46 stars 34 forks source link

Some fixes and additions #389

Closed pepedressingroom closed 1 month ago

pepedressingroom commented 10 months ago

Fixes

Additions

Ioney commented 9 months ago

just paste the link to the commit like so : https://github.com/zarillion/handynotes-plugins/pull/389/commits/f1b76a3e1fb83d350e1c5a846f16b0f5e79488fb https://github.com/zarillion/handynotes-plugins/pull/389/commits/f1b76a3e1fb83d350e1c5a846f16b0f5e79488fb

pepedressingroom commented 9 months ago

just paste the link to the commit like so : https://github.com/zarillion/handynotes-plugins/pull/389/commits/f1b76a3e1fb83d350e1c5a846f16b0f5e79488fb f1b76a3

Thank you @Ioney

Krovikan commented 9 months ago

@pepedressingroom You have a mistake in all locales and in Azure_span.lua

L["altar_of_decay_label"] must be L['altar_of_decay_label'].

Regards

pepedressingroom commented 9 months ago

L["altar_of_decay_label"] must be L['altar_of_decay_label']

Thank you @Krovikan

Krovikan commented 9 months ago

@pepedressingroom L['khadin_prof_note'] = 'Gana %d more {currency:%d}s to max out {spell:%d} profession tree.'

You can show me a sentence did it with %d replaced? Can be of any profession, only for translate accurate.

Regards

pepedressingroom commented 9 months ago

@pepedressingroom L['khadin_prof_note'] = 'Gana %d more {currency:%d}s to max out {spell:%d} profession tree.'

You can show me a sentence did it with %d replaced? Can be of any profession, only for translate accurate.

Regards

屏幕截图 2023-12-02 001910

@Krovikan I list how many currencies to max out tree nodes of the 2 professions for a player to decide either one to exchange Dragon Shards. My English is not good, and do you think the sentences make sense?

Regards.

zarillion commented 7 months ago

Looks like some globals need to be added to .luacheckrc still for the build to pass. I'm going to wait on merging these for now.

Ioney commented 1 month ago

@pepedressingroom Is there anything else you want to add to this PR?

should be possible, i think we just need the quest id and add another hook function

pepedressingroom commented 1 month ago

@loney

I've been AFK for round half a year, since the returning news of the china server. Due to my lacking of experience, this PR looks like a great mess. Maybe I should not add too many things in one PR, and please help look after this PR.

I still have some thought and data to add in Dragonflight, but it will take me some time to sort.

Ioney commented 1 month ago

@pepedressingroom you did a lot of commits since your last comment, are you still working on something or can i merge this PR?

pepedressingroom commented 1 month ago

@Ioney This PR seems ready to be merged now. Thank you for your guys help.