search

zarillion / handynotes-plugins

A collection of HandyNotes plugins for World of Warcraft.
Other
46 stars 34 forks source link

Add 'Just One More Thing' and more nodes for 'Clued In' #404

Closed pepedressingroom closed 1 month ago

pepedressingroom commented 7 months ago
  1. Add more nodes for 'Clued In'
  1. Add 'Just One More Thing' achievement https://github.com/zarillion/handynotes-plugins/pull/404/commits/b358d2bf3af049010d42c3b1b97eb69ce59510e1

Reference: Wowhead 'Just One More Thing' comments page

pepedressingroom commented 7 months ago

Is it the name _'just_one_more_thing'_ that causes the formatting issues?

Krovikan commented 7 months ago

@zarillion will check the error in Lint from the https://github.com/zarillion/handynotes-plugins/pull/404/commits/edf188f7733be78a894ed38eb71c4522d65f1709 commit.

Regards

zarillion commented 7 months ago

Your editor has been changing line endings. These files all had their line endings changed from LF to CRLF:

  plugins/10_Dragonflight/common.lua
  plugins/10_Dragonflight/zones/forbidden_reach2.lua
  plugins/10_Dragonflight/zones/ohnahran_plains.lua
  plugins/10_Dragonflight/zones/waking_shores.lua
  plugins/10_Dragonflight/zones/zaralek_cavern.lua
  plugins/10_Dragonflight/localization/deDE.lua
  plugins/10_Dragonflight/localization/enUS.lua
  plugins/10_Dragonflight/localization/esES.lua
  plugins/10_Dragonflight/localization/frFR.lua
  plugins/10_Dragonflight/localization/koKR.lua
  plugins/10_Dragonflight/localization/ruRU.lua
  plugins/10_Dragonflight/localization/zhCN.lua
  plugins/10_Dragonflight/localization/zhTW.lua

Make sure the line endings stay as LF so the actual diffs appear in the "Files changed" view.

Ioney commented 1 month ago

@pepedressingroom is this ready to merge?

pepedressingroom commented 1 month ago

Yes, it's ready to merge. Thanks for your guys help.