zarillion / handynotes-plugins

A collection of HandyNotes plugins for World of Warcraft.
Other
46 stars 34 forks source link

Add Profession items for TWW Zones #416

Closed tfmonk closed 1 month ago

tfmonk commented 1 month ago

Add Profession items for TWW Zones

Jewelcrafting Alchemy Enchanting Engineering Herbalism Leatherworking Tailoring Mining Skinning Inscription Blacksmithing

Dathwada commented 1 month ago

I'll fix the formatting for you.

tfmonk commented 1 month ago

thanks @Dathwada not 100% sure where im going wrong as i mirrored everything the best i can

tfmonk commented 1 month ago

why does formatting pass this was when say the Alchemy Earthen Iron Powder for Isle of dorn is one line and say the jewlcrafting Earthen Gem Pliers are over a couple of lines?

Dathwada commented 1 month ago

The formatter we use is configured to allow 80 characters per line (comments do not count). Some rules don't apply to the localization files. The formatter has many rules for formatting the code, I wouldn't try to do this manually.

dor.nodes[32456032] = PT.Alchemy({quest = 83840, id = 226265, parent = map.id}) -- Earthen Iron Powder (102 chars, but only 79 chars without the comment)

dor.nodes[34845219] = PT.Jewelcrafting({quest = 83891, id = 226317, parent = map.id}) -- Earthen Gem Pliers (107 chars, but 85 without the comment)

tfmonk commented 1 month ago

that makes sense, thanks for that information. If i do further updates i will leave the formatting if theres issues

tfmonk commented 1 month ago

I've gone through all the main profession items and added the information and reviewed all the ones that were there before, look like they are all done now

pepedressingroom commented 1 month ago

misspell: aquest = 83909

tfmonk commented 1 month ago

thanks @pepedressingroom its fixed now

tfmonk commented 1 month ago

Just updated a handful of rares tracking quests and added the rep gained from them