I took a look at this branch, and the behavior of some of the groups are indeed odd once this option is deselected. I see why you added the "Achievement Reward Tracking is off, therefore most Nodes will be hidden!" text to the top of the achievements section if those rewards are hidden. It causes most or all of the achievement nodes to just stop working entirely.
I think we should implement this as a rares-only toggle, since the display state of rares are never tied to achievement criteria. Instead of needing to display special text in the achievement menu section when this option is unchecked, we can just add extra text to the option saying it only affects rares. That covers the original ask here anyways.
I'll have to think more about where that option should live in the menus and what exactly it should say. The filtering will be more complex than the existing reward toggle logic since it needs to live in the Rare class instead of the base Node class.
I took a look at this branch, and the behavior of some of the groups are indeed odd once this option is deselected. I see why you added the "Achievement Reward Tracking is off, therefore most Nodes will be hidden!" text to the top of the achievements section if those rewards are hidden. It causes most or all of the achievement nodes to just stop working entirely.
I think we should implement this as a rares-only toggle, since the display state of rares are never tied to achievement criteria. Instead of needing to display special text in the achievement menu section when this option is unchecked, we can just add extra text to the option saying it only affects rares. That covers the original ask here anyways.
I'll have to think more about where that option should live in the menus and what exactly it should say. The filtering will be more complex than the existing reward toggle logic since it needs to live in the Rare class instead of the base Node class.