search

zarocknz / javascript-winwheel

Create spinning prize wheels on HTML canvas with Winwheel.js
http://dougtesting.net
MIT License
524 stars 362 forks source link

TweenMax depricated #100

Closed ductoanthanh closed 2 years ago

ductoanthanh commented 3 years ago

GSAP 3 was released with many improvements, including TweenMax

this.tween = TweenMax.to(this, this.animation.duration, properties);

can be changed to something like

import gsap from "gsap"; this.tween = gsap.to(this, this.animation.duration, properties);

just add gsap as your dependency

zarocknz commented 3 years ago

Thank you for brining this to my attention. I will look to update Winwheel.js to use the new gsap over the Christmas-new year break. Cheers.

SturmB commented 2 years ago

Apparently, this has not yet been implemented.

And there is no longer a download link for TweenMax (that I can find).

What can be done now for users who wish to use Winwheel? Are we just all out of luck?

SturmB commented 2 years ago

Never mind. It seems Winwheel will work (say that 3 times fast) even if using the latest version of GSAP 3. I guess they still have the old TweenMax code in it?

Still, in case it does get removed in the future, it would probably be a good idea to go ahead and update Winwheel to take advantage of the newer implementation of TweenMax in GSAP 3.