search

zarqa-ai / metta-motto

MIT License
6 stars 7 forks source link

some logging added needed for snet assistant #29

Closed Necr0x0Der closed 6 months ago

Necr0x0Der commented 6 months ago

@besSveta , this logging should be enough for now. It doesn't fully solve #22 , but at least some messages about errors should appear. Can you please check if it is the case for the example in #22 and possibly other situations. It seems to work for problems in chromadb, and some other cases (like wrong agent name), but maybe something is missing.

besSveta commented 6 months ago

@besSveta , this logging should be enough for now. It doesn't fully solve #22 , but at least some messages about errors should appear. Can you please check if it is the case for the example in #22 and possibly other situations. It seems to work for problems in chromadb, and some other cases (like wrong agent name), but maybe something is missing.

for the case #22 the logs are not written. maybe we should write logs on call of : raise TypeError, raise RuntimeError for #22 the error comes form here https://github.com/zarqa-ai/metta-motto/blob/bb9848c02aed8ab28f9c16213239718b82a95ec1/motto/llm_gate.py#L178

Necr0x0Der commented 6 months ago

They are written to console and I checked #22 example and see the error message, so it is not kept silent. Whether to create a log file or use console is up to the caller.