zarquon42b / Morpho

R-package providing a toolset for (3D-based) Geometric Morphometrics
51 stars 16 forks source link

Landmark projection issue #38

Closed travispark closed 8 months ago

travispark commented 9 months ago

Hi Stefan

I'm trying to use slider3d to resample and slide my landmarks and I can't figure out how to resolve the following error:

 slided4.all <- slider3d(newpts2, SMvector= my_curves$Sliding.LMs,
+                             outlines = my_curves$Curves, sur.path = "./clean_meshes", sur.name = NULL, 
+                             meshlist = meshlist, ignore = NULL,
+                             sur.type = "ply", tol = 1e-10, deselect = FALSE, inc.check = FALSE,
+                             recursive = TRUE, iterations = 3, initproc = TRUE,
+                             pairedLM = 0, mc.cores = 1, bending=TRUE,
+                             fixRepro = FALSE,stepsize=0.02)
Points will be initially projected onto surfaces 
 ------------------------------------------- 
Error in t.default(reprotmp$vb[1:3, ]) : argument is not a matrix

I've checked all my ply files, as well as cleaning them using Rvcg. As best as I can tell, there's some sort of issue during the projection stage? I can send you the data if you aren't immediately clear on what could be causing the issue.

Cheers

Travis

zarquon42b commented 9 months ago

Hi Travis, can you please send me a minimal example with code and data to debug to my email in the DESCRIPTION file. I'll have a look at it.

zarquon42b commented 9 months ago

Hi Travis, can you please send me a minimal example with code and data to debug to my email in the DESCRIPTION file. I'll have a look at it.

I just found that old issue that had the same problem but could be explained by degenerate meshes, but from your comment I guess you already tried that.

travispark commented 9 months ago

Hi Travis, can you please send me a minimal example with code and data to debug to my email in the DESCRIPTION file. I'll have a look at it.

I just found that old issue that had the same problem but could be explained by degenerate meshes, but from your comment I guess you already tried that.

Hi Stefan

Yes, I did see that old issue, and cleaned my meshes using Rvcg as a result of it, but still seem to be having trouble. In the previous issue though, based on their code they seem to have completed the projection stage, whereas my error appears during that stage.

I've emailed you the code and a subsample of the data to play around with. Let me know if you need anything else.

Cheers

Travis

travispark commented 8 months ago

Hi Stefan, just wondering if you had a chance ot have a look at this? I've been unable to figure out. A friend said it might be due my meshlist not being in the same order as the specimens in the data array, but mine do appear to be the same and I'm still getting the same error message.

Cheers

Travis

zarquon42b commented 8 months ago

Sorry Travis, my apologies. I was busy. I will try to have a look the next few days. Best Stefan

travispark commented 8 months ago

Hi Stefan, I think it's now working for me. I left meshlist as NULL instead of trying to input something into that parameter and it seems to have worked. Is that likely to have been the issue or has it in fact not worked correctly?

Cheers

Travis

zarquon42b commented 8 months ago

Hi Travis, meshlist is only needed if you have the meshes stored in a list in the same order as the landmarks. Otherwise it will try to read the files from sur.path. Sorry for my delay but I had health issue. Best Stefan

Travis Park @.***> schrieb am Mo., 18. März 2024, 03:51:

Hi Stefan, I think it's now working for me. I left meshlist as NULL instead of trying to input something into that parameter and it seems to have worked. Is that likely to have been the issue or has it in fact not worked correctly?

Cheers

Travis

— Reply to this email directly, view it on GitHub https://github.com/zarquon42b/Morpho/issues/38#issuecomment-2002780074, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALSCV34362BDR6K6BONTF3YYZJBTAVCNFSM6AAAAABEBDIKISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBSG44DAMBXGQ . You are receiving this because you commented.Message ID: @.***>

travispark commented 8 months ago

Hi Travis, meshlist is only needed if you have the meshes stored in a list in the same order as the landmarks. Otherwise it will try to read the files from sur.path. Sorry for my delay but I had health issue. Best Stefan Travis Park @.> schrieb am Mo., 18. März 2024, 03:51: Hi Stefan, I think it's now working for me. I left meshlist as NULL instead of trying to input something into that parameter and it seems to have worked. Is that likely to have been the issue or has it in fact not worked correctly? Cheers Travis — Reply to this email directly, view it on GitHub <#38 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALSCV34362BDR6K6BONTF3YYZJBTAVCNFSM6AAAAABEBDIKISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBSG44DAMBXGQ . You are receiving this because you commented.Message ID: @.>

Hi Stefan

No problems at all about the delay, I hope you are feeling better. Glad to know that this should be the issue solved for me.

Cheers

Travis