zarquon42b / Rvcg

R-package providing mesh manipulation routines from VCGLIB
Other
25 stars 10 forks source link

Remove unused tol parameter #18

Closed dfsp-spirit closed 3 years ago

dfsp-spirit commented 3 years ago

This PR:

It's easiest to see what is being done by looking at the commits separately, as the third makes it hard to tell what has been done when looking at the combined changes.

One could alternatively implement the parameter, but given the speed of the current solution, I guess that it's not really needed for most meshes (and filtering afterwards can be done in R anyways).

dfsp-spirit commented 3 years ago

@zarquon42b Any opinion on this?

zarquon42b commented 3 years ago

Sorry, I was drowning in work.

dfsp-spirit commented 3 years ago

No worries, I thought you had not noticed the PR. Happened to me once.

And once I mark something as read, it's gone for good. ;)