zarquon42b / Rvcg

R-package providing mesh manipulation routines from VCGLIB
Other
25 stars 10 forks source link

Rvcg::vcgCurve returns zeros #30

Closed nialsiG closed 2 years ago

nialsiG commented 2 years ago

OS: Windows 10 R version 4.2.0

For an unknown reason, vcgCurve returns arrays of zeros regardless of the surface used as mesh

Here is a reproductible example:

library(Rvcg)
data(humface)
curv <- vcgCurve(humface)

summary(curv$meanitmax)
summary(curv$gaussitmax)
summary(curv$K1) #edit: works normally
summary(curv$k2) #edit: works normally
zarquon42b commented 2 years ago

Hi, yes, this is an error introduced by some restructuring in vcglib. I'm on it.

This

summary(curv$k1)
summary(curv$k2)

however, needs to be with capital letters and is working as expected.

summary(curv$**K**1)
summary(curv$**K**2)
zarquon42b commented 2 years ago

Please test: You can install it via devtools::install_github("zarquon42b/Rvcg", ref="fix-vcgCurve")

nialsiG commented 2 years ago

My mistake, you are right for principal curvatures K1 and K2. I edited the initial post.

After installing the correction, vcgCurve works perfectly. Well done, and thank you !