Hypothesis test broadcasting

zarr-developers / VirtualiZarr

Create virtual Zarr stores from archival data files using xarray syntax

https://virtualizarr.readthedocs.io/en/latest/

Apache License 2.0

95 stars 18 forks source link

Hypothesis test broadcasting #139

Closed TomNicholas closed 3 months ago

TomNicholas commented 3 months ago

This definitely found a few bugs, but I'm not sure there's any point fixing them in main when I'm about to change the entire implementation in #107 anyway...

[x] Works towards #9 for array functions on the ManifestArray class
[x] Tests added
[ ] ~~Changes are documented in docs/releases.rst~~
[ ] ~~New functions/methods are listed in api.rst~~

TomNicholas commented 3 months ago

I basically reverted this in #107 (specifically https://github.com/zarr-developers/VirtualiZarr/pull/107/commits/dc824bb8bce87244ac400b89f7cdfe91cb3bd0dc) because I realised I misunderstood what hypothesis.extra.numpy.broadcastable_shapes does, and so this test was generating invalid arguments to broadcast_to.

The updated test did still reveal a real bug though, which is tracked in #146.