zarr-developers / VirtualiZarr

Create virtual Zarr stores from archival data files using xarray syntax
https://virtualizarr.readthedocs.io/en/latest/
Apache License 2.0
68 stars 10 forks source link

Bug in broadcast_to logic #146

Closed TomNicholas closed 2 weeks ago

TomNicholas commented 2 weeks ago

There is some kind of bug in my logic that implements broadcast_to for ManifestArrays backed by dicts - see https://github.com/zarr-developers/VirtualiZarr/commit/6d53d4c4353d1b37fd51778d1d46b58769a561d6.

I think because we're about to replace that logic with #107 (which fixes the bug by delegating the hard part to numpy), there is not much point in fixing it in main too.

TomNicholas commented 2 weeks ago

Closed by #107