Closed maresb closed 2 months ago
@TomNicholas, I think I'm ready for another round of review, whenever you are.
Sorry for the slow review @maresb ! Just some very small comments here.
Sorry for the slow review @maresb ! Just some very small comments here.
No worries, no rush, and thanks so much for maintaining!!!
I think I'm all caught up with your comments.
I don't think you're asking for a change regarding the NotImplementedError
on inlined data, but I'm not certain about this.
Please let me know if you'd like any further changes, or if you'd like me to rebase.
Thanks @TomNicholas!
I think this looks good, thank you @maresb !
I'm trying to open a Zarr v2. I couldn't find a good obvious way to do this, so my attempt was:
This fails here in unpacking because kerchunk produces reference entries of the form
[path]
instead of[path, length, offset]
.I was wondering if I could work around this by
stat
ing the chunks, and sure enough it worked! (See my second commit.)I'd love to get some feedback on this, including if there's a better way to open v2 zarrs.
In preparation for my second commit I needed to clean up some types. To make things more precise and clean, I tell a minor lie: that the
[path, offset, length]
lists are tuples. This was done in the spirit of duck typing, and I'd argue is more semantically accurate. (Not to mention that tuples serialize to lists in JSON.)docs/releases.rst
api.rst