zarr-developers / VirtualiZarr

Create virtual Zarr stores from archival data files using xarray syntax
https://virtualizarr.readthedocs.io/en/stable/api.html
Apache License 2.0
124 stars 24 forks source link

`open_virtual_dataset` error with TEMPO dmr++ #237

Closed danielfromearth closed 2 weeks ago

danielfromearth commented 2 months ago

Trying to open a DMR++ file from the Tropospheric Emissions: Monitoring of Pollution (TEMPO) satellite-based air quality instrument results in the following TypeError:

result = open_virtual_dataset("https://data.asdc.earthdata.nasa.gov/asdc-prod-protected/TEMPO/TEMPO_NO2_L2_V03/2024.07.25/TEMPO_NO2_L2_V03_20240725T114404Z_S002G06.nc.dmrpp", indexes={}, filetype="dmrpp", reader_options={"storage_options": fs.storage_options})

temp

ayushnag commented 2 months ago

Thanks for raising this issue @danielfromearth! This dataset has variables and attributes in the root group and the current code doesn't have logic to handle that. There is already have group parsing logic, I just need to add a case for the root group and your use case will be patched soon.

danielfromearth commented 1 month ago

Hi @ayushnag, I was away from this for the past month on some personal leave. Has there been any progress on this? And either way, would it help to catch up soon (perhaps via Openscapes) about this?

ayushnag commented 1 month ago

Hey @danielfromearth! Yes this fix uncovered quite a few other issues about groups that I have fixed. I will post a PR very soon

TomNicholas commented 1 month ago

@ayushnag FYI there's no need to wait until the PR is fully working before opening it - I like to open half-baked PRs and mark them as draft just so that people can see what's being worked on

ayushnag commented 1 month ago

Good idea, I have opened it now!