search

zarr-developers / VirtualiZarr

Create virtual Zarr stores from archival data files using xarray syntax
https://virtualizarr.readthedocs.io/en/stable/api.html
Apache License 2.0
124 stars 24 forks source link

mypy spontaneously reporting new error #274

Closed sharkinsspatial closed 1 week ago

sharkinsspatial commented 1 month ago

mypy has begun reporting a new error without any changes to the underlying code or from what I can tell any changes in the versions of the mypy packages installed.

virtualizarr/readers/common.py:34: error: Cannot assign to a type  [misc]
virtualizarr/readers/common.py:34: error: Incompatible types in assignment (expression has type "<typing special form>", variable has type "type[DataTree]")  [assignment]
virtualizarr/readers/common.py:37: error: Definition of "__array__" in base class "ManifestArray" is incompatible with definition in base class "ExplicitlyIndexed"  [misc]

This error just began appearing in the Github action and I am unable to reproduce it locally.

TomNicholas commented 1 month ago

Maybe same as https://github.com/pydata/xarray/issues/9624?

TomNicholas commented 1 week ago

Closing as this seems to be resolved in more recent PRs.

virtualizarr/readers/common.py:34: error: Incompatible types in assignment (expression has type "<typing special form>", variable has type "type[DataTree]") [assignment]

I think I fixed this one in https://github.com/zarr-developers/VirtualiZarr/pull/284

virtualizarr/readers/common.py:37: error: Definition of "__array__" in base class "ManifestArray" is incompatible with definition in base class "ExplicitlyIndexed" [misc]

I fixed this in https://github.com/zarr-developers/VirtualiZarr/pull/282