Closed ivirshup closed 2 months ago
Hello @ivirshup! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.91%. Comparing base (
1be12d3
) to head (47f1afe
).
Allow read-only arrays to be encoded with VLenUTF8
Arguably this should be tested and potentially fixed for all codecs.
Question: Is this implementation fine? I've done very little Cython, so I have no idea if there are any downsides to this.
TODO: