Closed dstansby closed 2 weeks ago
@zarrdevelopers any chance someone could approve the workflows here?
@joshmoore or @jakirkham, please approve the workflows.
Looks like Josh did that, but CI is failing on macOS. Maybe we are still missing something?
the last time the macOS wheel builds were working they were using the macos-12 image, so I've updated that for now. Can someone approve workflows for me again?
Launched
For debugging, https://github.com/zarr-developers/numcodecs/actions/runs/8027488593 is a build on macOS 12 that passed.
Approved again
David, if you send a small fix PR to Numcodecs (maybe a small doc fix?), we could merge that, which should green light CI to run on your PRs. That way we are not holding you up in your testing efforts
Also thank you for digging into this issue! 🙏
Ah good idea! Here we go: https://github.com/zarr-developers/numcodecs/pull/530
At least it looks like I fixed the issue here, it was the max version of clang that needed pinning.
Great, this should finally be fixed now!
Codecov reporting is flaky. Could you try to add a new (empty) commit to trigger it again?
I've pinned numpy here too just to get the tests working, I can work on numpy 2.0 support in another PR.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.91%. Comparing base (
4abe4be
) to head (bd3a7a7
). Report is 2 commits behind head on main.
Fab, this is all green now!
Thanks all! 🙏
GitHub updated the latest macOS runners to be arm-based, causing the CI to fail. This makes sure the existing CI is using intel based macOS runners - we can always add support for arm-based testing in a follow up PR.
Fixes https://github.com/zarr-developers/numcodecs/issues/527