zarr-developers / numcodecs

A Python package providing buffer compression and transformation codecs for use in data storage and communication applications.
http://numcodecs.readthedocs.io
MIT License
121 stars 82 forks source link

Run macOS CI on intel based runners + pin max clang version #528

Closed dstansby closed 2 weeks ago

dstansby commented 1 month ago

GitHub updated the latest macOS runners to be arm-based, causing the CI to fail. This makes sure the existing CI is using intel based macOS runners - we can always add support for arm-based testing in a follow up PR.

Fixes https://github.com/zarr-developers/numcodecs/issues/527

dstansby commented 1 month ago

@zarrdevelopers any chance someone could approve the workflows here?

MSanKeys963 commented 1 month ago

@joshmoore or @jakirkham, please approve the workflows.

jakirkham commented 1 month ago

Looks like Josh did that, but CI is failing on macOS. Maybe we are still missing something?

dstansby commented 1 month ago

the last time the macOS wheel builds were working they were using the macos-12 image, so I've updated that for now. Can someone approve workflows for me again?

joshmoore commented 1 month ago

Launched

dstansby commented 1 month ago

For debugging, https://github.com/zarr-developers/numcodecs/actions/runs/8027488593 is a build on macOS 12 that passed.

jakirkham commented 1 month ago

Approved again

David, if you send a small fix PR to Numcodecs (maybe a small doc fix?), we could merge that, which should green light CI to run on your PRs. That way we are not holding you up in your testing efforts

Also thank you for digging into this issue! 🙏

dstansby commented 1 month ago

Ah good idea! Here we go: https://github.com/zarr-developers/numcodecs/pull/530

At least it looks like I fixed the issue here, it was the max version of clang that needed pinning.

dstansby commented 1 month ago

Great, this should finally be fixed now!

normanrz commented 2 weeks ago

Codecov reporting is flaky. Could you try to add a new (empty) commit to trigger it again?

dstansby commented 2 weeks ago

I've pinned numpy here too just to get the tests working, I can work on numpy 2.0 support in another PR.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.91%. Comparing base (4abe4be) to head (bd3a7a7). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #528 +/- ## ========================================== - Coverage 99.91% 99.91% -0.01% ========================================== Files 59 59 Lines 2323 2320 -3 ========================================== - Hits 2321 2318 -3 Misses 2 2 ``` [see 2 files with indirect coverage changes](https://app.codecov.io/gh/zarr-developers/numcodecs/pull/528/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zarr-developers)
dstansby commented 2 weeks ago

Fab, this is all green now!

jakirkham commented 1 week ago

Thanks all! 🙏