zarr-developers / numcodecs

A Python package providing buffer compression and transformation codecs for use in data storage and communication applications.
http://numcodecs.readthedocs.io
MIT License
121 stars 82 forks source link

Bump min Python to 3.10 #531

Closed dstansby closed 2 weeks ago

dstansby commented 1 month ago

As per SPEC 0 (which it says that zarr is signed up to), drop support from Python 3.8/3.9.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.91%. Comparing base (4abe4be) to head (e144faa). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #531 +/- ## ========================================== - Coverage 99.91% 99.91% -0.01% ========================================== Files 59 59 Lines 2323 2318 -5 ========================================== - Hits 2321 2316 -5 Misses 2 2 ``` | [Files](https://app.codecov.io/gh/zarr-developers/numcodecs/pull/531?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zarr-developers) | Coverage Δ | | |---|---|---| | [numcodecs/registry.py](https://app.codecov.io/gh/zarr-developers/numcodecs/pull/531?src=pr&el=tree&filepath=numcodecs%2Fregistry.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zarr-developers#diff-bnVtY29kZWNzL3JlZ2lzdHJ5LnB5) | `100.00% <100.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/zarr-developers/numcodecs/pull/531/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zarr-developers)
martindurant commented 1 month ago

This would be a good time to ensure numpy 2 support, if it isn't already done.

dstansby commented 1 month ago

There's an issue here: https://github.com/zarr-developers/numcodecs/issues/521; I'm happy to take a look, but don't want to open too many PRs at once 😄

normanrz commented 2 weeks ago

It would be great if you could have a look at numpy 2 support.

I wonder if we should remove line of code that codecov complains about? https://app.codecov.io/gh/zarr-developers/numcodecs/pull/531/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zarr-developers

dstansby commented 2 weeks ago

This is good to go - the yellow CI jobs are ones no longer run as they're old versions of Python. I think removing these requires some manual adjustment of repository settings from an admin.

normanrz commented 2 weeks ago

I removed the requirement for py 3.8 and 3.9. Codecov still needs a bump.

dstansby commented 2 weeks ago

From one of the builds:

[2024-06-19T09:51:18.726Z] ['error'] There was an error running the uploader: Error uploading to https://codecov.io: Error: There was an error fetching the storage URL during POST: 429 - {'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 2676s.', code='throttled')}

So I think someone needs to set up using a codecov token for codecov to start working again.

normanrz commented 2 weeks ago

Alright. I added the token.