Closed dstansby closed 2 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.91%. Comparing base (
4abe4be
) to head (e144faa
). Report is 3 commits behind head on main.
This would be a good time to ensure numpy 2 support, if it isn't already done.
There's an issue here: https://github.com/zarr-developers/numcodecs/issues/521; I'm happy to take a look, but don't want to open too many PRs at once 😄
It would be great if you could have a look at numpy 2 support.
I wonder if we should remove line of code that codecov complains about? https://app.codecov.io/gh/zarr-developers/numcodecs/pull/531/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zarr-developers
This is good to go - the yellow CI jobs are ones no longer run as they're old versions of Python. I think removing these requires some manual adjustment of repository settings from an admin.
I removed the requirement for py 3.8 and 3.9. Codecov still needs a bump.
From one of the builds:
[2024-06-19T09:51:18.726Z] ['error'] There was an error running the uploader: Error uploading to https://codecov.io: Error: There was an error fetching the storage URL during POST: 429 - {'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 2676s.', code='throttled')}
So I think someone needs to set up using a codecov token for codecov to start working again.
Alright. I added the token.
As per SPEC 0 (which it says that zarr is signed up to), drop support from Python 3.8/3.9.