zarr-developers / numcodecs

A Python package providing buffer compression and transformation codecs for use in data storage and communication applications.
http://numcodecs.readthedocs.io
MIT License
128 stars 88 forks source link

Fail CI if codecov doesn't upload #638

Open dstansby opened 1 week ago

dstansby commented 1 week ago

On https://github.com/zarr-developers/numcodecs/pull/637 and other PRs, it looks like the code coverage is failing because some reports fail to upload, but this isn't failing the CI jobs so it's not obvious.

This PR changes that so CI fails if coverage does not succesfully upload to codecov.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.88%. Comparing base (ad1ad67) to head (9013215).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #638 +/- ## ======================================= Coverage 99.88% 99.88% ======================================= Files 62 62 Lines 2708 2708 ======================================= Hits 2705 2705 Misses 3 3 ```
dstansby commented 1 week ago

Looks like we're running into https://github.com/codecov/codecov-action/issues/1643 😢