Enable warn_unreachable for mypy - Githubissues

zarr-developers / zarr-python

An implementation of chunked, compressed, N-dimensional arrays for Python.

http://zarr.readthedocs.io/

MIT License

1.44k stars 272 forks source link

Enable warn_unreachable for mypy #1937

Closed dstansby closed 2 months ago

dstansby commented 2 months ago

One of the last parts of https://github.com/zarr-developers/zarr-python/issues/1783, a few simple fixes and the ignores I put in because it looks like those code paths will go when v2 is completely gone anyway?

TODO:

[ ] Add unit tests and/or doctests in docstrings
[ ] Add docstrings and API docs for any new/modified user-facing classes and functions
[ ] New/modified features documented in docs/tutorial.rst
[ ] Changes documented in docs/release.rst
[ ] GitHub Actions have all passed
[ ] Test coverage is 100% (Codecov passes)