Closed dcherian closed 1 week ago
Thanks @dcherian -- looks good to me. No idea why Appveyor isn't running though.
@zarr-developers/steering-council -- I don't have access to our appveyor account. Seems like another reason to address https://github.com/zarr-developers/zarr-python/issues/1905
OK I'll try and add a hypothesis test for this later.
@jhamman I have reproduced the failure with a hypothesis test now (#1746 ).
This branch makes that test always pass (it seems like)
Should I point that PR at main or V3?
@dcherian - My preference is that we get #1746 into the v3
branch or both.
No idea why Appveyor isn't running though.
"AppVeyor was unable to build non-mergeable pull request" -- perhaps it was the change of the default branch?
@zarr-developers/steering-council -- I don't have access to our appveyor account. Seems like another reason to address #1905
Not sure how I log in either at this point?! (Things look to have changed)
I'd propose we get this and any other regressions out as 2.18.3 (ignoring the job failure).
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.98%. Comparing base (
c72d0e2
) to head (1b09c5e
). Report is 2 commits behind head on main.
Fixes #1931
TODO: