search

zarr-developers / zarr-python

An implementation of chunked, compressed, N-dimensional arrays for Python.
http://zarr.readthedocs.io/
MIT License
1.44k stars 272 forks source link

[v3] skew in store class attributes #1962

Open d-v-b opened 2 months ago

d-v-b commented 2 months ago

LocalStore has a root attribute, but RemoteStore has a path attribute. I believe they have the same function.

We should eventually pick one name for this, and figure out how MemoryStore fits into the picture. In v2, I have been bitten by the fact that MemoryStore does not have a path attribute, so it would be nice to come up with a consistent API here.

Personally I lean toward "path" over "root" because of the similarity to URL semantics, but we should just pick 1 thing eventually.

d-v-b commented 2 months ago

If we did put a path attribute on our Store classes, then this would raise the question of where StorePath fits, because it also has a path attribute, so we could end up with confusing references to store_path.store.path vs store_path.path.