Adapt storage tests for changes in fsspec (#1819) (#1679)

zarr-developers / zarr-python

An implementation of chunked, compressed, N-dimensional arrays for Python.

http://zarr.readthedocs.io/

MIT License

1.41k stars 267 forks source link

Adapt storage tests for changes in fsspec (#1819) (#1679) #1970

Open AdamWill opened 4 weeks ago

AdamWill commented 4 weeks ago

This is adapted from the fixes that were rolled into https://github.com/zarr-developers/zarr-python/pull/1785 for the v3 branch.

TODO:

[ ] GitHub Actions have all passed
[ ] Test coverage is 100% (Codecov passes)

Deleted TODO items are not applicable as this changes no code, only tests.

AdamWill commented 4 weeks ago

On v3 the check in test_hierarchy was commented out entirely, but that seems excessive to me. The comment # no exception raised if path does not exist or is leaf indicates the primary point of these checks is to make sure the listdir calls run without causing an assertion, and we can still do that, and check that the result is one of the two we know are possible.