`parse_shapelike` allows 0 - Githubissues

zarr-developers / zarr-python

An implementation of chunked, compressed, N-dimensional arrays for Python.

https://zarr.readthedocs.io

MIT License

1.47k stars 274 forks source link

`parse_shapelike` allows 0 #1979

Closed d-v-b closed 3 months ago

d-v-b commented 3 months ago

parse_shapelike allows shape values to be 0
parse_shapelike allows the empty tuple ()
parse_shapelike rejects negative integers correctly (in main this is not working)
expands tests accordingly

response to #1976 and #1977, although I'm not sure it addresses those concerns entirely, since I haven't changed array indexing tests at all

TODO:

[ ] Add unit tests and/or doctests in docstrings
[ ] Add docstrings and API docs for any new/modified user-facing classes and functions
[ ] New/modified features documented in docs/tutorial.rst
[ ] Changes documented in docs/release.rst
[ ] GitHub Actions have all passed
[ ] Test coverage is 100% (Codecov passes)