Open d-v-b opened 1 month ago
@martindurant i'm on flaky train internet and the github web API is giving me inconsistent signals about whether you have been requested for review; to be clear, I would appreciate your review :)
list_prefix(prefix=foo) now consistently returns keys with the shared prefix foo stripped. I'd be fine altering this to return absolute keys instead.
What matters is how we intend to call it! fsspec likes to provide full paths (but has explicit prefix interfaces) - of course it's fine to tailor the situation to what we need, but I don't really know what that is.
I would appreciate your review
I may have got a notification or a few.
list_prefix
for stores.list_prefix(prefix=foo)
now consistently returns keys with the shared prefixfoo
stripped. I'd be fine altering this to return absolute keys instead.list_prefix
on theStoreTests
base class_set_dict(Mapping[str, Buffer])
method to stores that allows declaring a collection of key: value pairs to write to storage. The primary usage is to make store tests simpler via a declarative API. I also suspect that making tests simpler anticipates making other code simpler. The default implementation of_set_dict
simply wrapsstore.set
, but it's easy to imagine fancier batching / transaction implementations._set_dict
.TODO: