Stateful store tests - Githubissues

e-marshall commented 1 month ago

This is a PR that implements stateful tests for Zarr MemoryStores.

TODO items below:

I added docstrings to new classes, functions
I don't think any changes need to be made to tutorial.rst
I wasn't sure if these changes should be added in release.rst ?
GH actions pass
I wasn't sure where to find codecov results, but didn't see a notification that it failed

TODO:

[ ] Add unit tests and/or doctests in docstrings
[ ] Add docstrings and API docs for any new/modified user-facing classes and functions
[ ] New/modified features documented in docs/tutorial.rst
[ ] Changes documented in docs/release.rst
[ ] GitHub Actions have all passed
[ ] Test coverage is 100% (Codecov passes)

e-marshall commented 4 weeks ago

thanks @dcherian ! thanks for all your help, fun to work with you and Seba on this!

e-marshall commented 4 weeks ago

thanks @jhamman ! I made these changes on https://github.com/zarr-developers/zarr-python/pull/2070/commits/d63df09a04503b0f36323b27933597ba60dd5652. happy to tweak/shorten the statemachine docstring if it seems too long

e-marshall commented 4 weeks ago

thanks @jhamman !

dcherian commented 4 weeks ago

Can we merge so that one might add list_prefix? #2064

d-v-b commented 4 weeks ago

Can we merge so that one might add list_prefix? #2064

I am working on getting that PR updated and ready

dcherian commented 4 weeks ago

Right, I meant that we could merge this PR so that we can add list_prefix to the stateful tests in that PR

zarr-developers / zarr-python