zarr-developers / zarr-python

An implementation of chunked, compressed, N-dimensional arrays for Python.
https://zarr.readthedocs.io
MIT License
1.45k stars 273 forks source link

Deprecate N5Store #2103

Closed jhamman closed 2 weeks ago

jhamman commented 3 weeks ago

closed https://github.com/zarr-developers/zarr-python/issues/2085

TODO:

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.98%. Comparing base (d1b92b5) to head (27b800e). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2103 +/- ## ======================================= Coverage 99.98% 99.98% ======================================= Files 38 38 Lines 14714 14718 +4 ======================================= + Hits 14712 14716 +4 Misses 2 2 ``` | [Files](https://app.codecov.io/gh/zarr-developers/zarr-python/pull/2103?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zarr-developers) | Coverage Δ | | |---|---|---| | [zarr/n5.py](https://app.codecov.io/gh/zarr-developers/zarr-python/pull/2103?src=pr&el=tree&filepath=zarr%2Fn5.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zarr-developers#diff-emFyci9uNS5weQ==) | `100.00% <100.00%> (ø)` | |
d-v-b commented 2 weeks ago

We should get the same warning in for N5FSStore, happy to do that myself as needed

jhamman commented 2 weeks ago

We should get the same warning in for N5FSStore, happy to do that myself as needed

I did it :)