search

zarr-developers / zarr-python

An implementation of chunked, compressed, N-dimensional arrays for Python.
https://zarr.readthedocs.io
MIT License
1.45k stars 273 forks source link

Store ABC doesn't match spec #2104

Closed dcherian closed 3 weeks ago

dcherian commented 3 weeks ago

Zarr version

irrelevant

Numcodecs version

irrelevant

Python Version

irrelevant

Operating System

irrelevant

Installation

irrelevant

Description

https://zarr-specs.readthedocs.io/en/latest/v3/core/v3.0.html#abstract-store-interface lists erase_values and erase_prefix which are not present in https://github.com/zarr-developers/zarr-python/blob/v3/src/zarr/abc/store.py.

Also erase has been renamed to delete. it would be good to update one of the two so that both are consistent.

Steps to reproduce

irrelevant

Additional output

No response

jhamman commented 3 weeks ago

I opened https://github.com/zarr-developers/zarr-specs/issues/307 to clarify that the ABC and the spec need not match. However, we should add the erase_* methods (or something similar).

jhamman commented 3 weeks ago

I'm going to close this in favor of the work in the spec repo to clarify the abstract store interface. I'll open a new issue with erase/delete/rename store methods.

See https://github.com/zarr-developers/zarr-python/issues/2108