Enforce ruff/flake8-type-checking rules (TCH)

zarr-developers / zarr-python

An implementation of chunked, compressed, N-dimensional arrays for Python.

https://zarr.readthedocs.io

MIT License

1.45k stars 273 forks source link

Enforce ruff/flake8-type-checking rules (TCH) #2110

Closed DimitriPapadopoulos closed 6 days ago

DimitriPapadopoulos commented 2 weeks ago

https://docs.astral.sh/ruff/rules/#flake8-type-checking-tch

TODO:

[ ] Add unit tests and/or doctests in docstrings
[ ] Add docstrings and API docs for any new/modified user-facing classes and functions
[ ] New/modified features documented in docs/tutorial.rst
[ ] Changes documented in docs/release.rst
[ ] GitHub Actions have all passed
[ ] Test coverage is 100% (Codecov passes)

DimitriPapadopoulos commented 1 week ago

Attempted to rebase, but something seems very wrong. I see conflicts between TCH rules and F821. It might be a ruff issue, I would like to upgrade to 0.6 before I start investigating.