search

zarr-developers / zarr-python

An implementation of chunked, compressed, N-dimensional arrays for Python.
https://zarr.readthedocs.io
MIT License
1.53k stars 284 forks source link

bug in v2 codec pipeline #2501

Open dcherian opened 4 hours ago

dcherian commented 4 hours ago

Zarr version

main

Description

There is a bug in these lines:

cdata is not of type bytes in the else clause:

https://github.com/zarr-developers/zarr-python/blob/eb85ee7ba32df4983b80ae9e60686e7d2f35349e/src/zarr/codecs/_v2.py#L80-L86

cc @normanrz

Steps to reproduce

This is triggering failures in xarray's test suite. I haven't succeeded at making a minimal reproducer.

Additional output

No response

dcherian commented 4 hours ago

Ah this occurs when self.filters is None and self.compressor is None