v1 and v2 specs - Githubissues

zarr-developers / zarr-specs

Zarr core protocol for storage and retrieval of N-dimensional typed arrays

https://zarr-specs.readthedocs.io/

Creative Commons Attribution 4.0 International

88 stars 28 forks source link

Closed d-v-b closed 10 months ago

d-v-b commented 1 year ago

I copy+pasted v1 and v2 from zarr-python. Is there any reason not to keep all the specs in one place?

Also, I added some QOL stuff to gitignore.

MSanKeys963 commented 1 year ago

Hi @d-v-b.

Thanks for working on this. It'd be good to keep specs in a single place. I think we should also remove the v1 and v2 specs from https://zarr.readthedocs.io/ and hyperlink them to the new page on https://zarr-specs.readthedocs.io/.

joshmoore commented 12 months ago

What's the next step here, @MSanKeys963 & @d-v-b? Get this in and then remove from zarr-python? Both at the same time?

d-v-b commented 12 months ago

I think we could add them here first, then remove them from zarr python + update the relevant links?

jbms commented 12 months ago

Since there are many links to the old v2 location (I don't know about v1) it would be nice to keep them working somehow.

joshmoore commented 12 months ago

:100: Big fan of not breaking URLs.

MSanKeys963 commented 11 months ago

I've reviewed this PR thoroughly for any broken links and added https://github.com/zarr-developers/zarr-python/pull/1582 to remove spec v1 and v2.

I'd agree with @d-v-b to merge this PR first and then review and merge the https://github.com/zarr-developers/zarr-python/pull/1582.

MSanKeys963 commented 11 months ago

@d-v-b - if you could please look at my review, we can go ahead with this PR soon.

After this is merged, we can also go ahead with https://github.com/zarr-developers/zarr-python/pull/1582 as well.

MSanKeys963 commented 11 months ago

Both the v1 and v2 specs looks good now.

Thanks @jbms!