search

zarr-developers / zarr-specs

Zarr core protocol for storage and retrieval of N-dimensional typed arrays
https://zarr-specs.readthedocs.io/
Creative Commons Attribution 4.0 International
88 stars 28 forks source link

Possible error in Chunk Encoding section #285

Closed brandon-neth closed 9 months ago

brandon-neth commented 10 months ago

In the second on the requirement for codecs to support compute_encoded_representation_type, there is the following sentence: "In the case of a decoded representation that is a multi-dimensional array, the shape and data type of the encoded representation must be computable based only on the shape and data type, but not the actual element values, of the encoded representation."

Is this is supposed to be "computable based only on the shape and data type but not the actual element value, of the decoded representation?" The existing sentence seems tautological.

jbms commented 10 months ago

Yes, that is correct, thanks for pointing that out. Do you want to submit a pr to fix it?

brandon-neth commented 9 months ago

Yes, that is correct, thanks for pointing that out. Do you want to submit a pr to fix it?

Sure, I'll get it up for yall sometime tomorrow probably!