zarr-developers / zarr_implementations

MIT License
39 stars 16 forks source link

created a directory netcdf-java #58

Closed JacinthEsther closed 1 year ago

jakirkham commented 1 year ago

Would it make sense to update .gitignore to help filter these out?

joshmoore commented 1 year ago

Would it make sense to update .gitignore to help filter these out?

Almost certainly! :+1:

JacinthEsther commented 1 year ago

I don't quite understand the response please

jakirkham commented 1 year ago

Think Josh is saying to drop the Maven files (though I could be misunderstanding)

joshmoore commented 1 year ago

I don't quite understand the response please

I think there should only be three files in this PR, @JacinthEsther. Currently there are 67 files:

https://github.com/zarr-developers/zarr_implementations/pull/58/files

The files should be named "App.java", "pom.xml", and "generate_data.sh". They should all be in the netcdf-java directory.

joshmoore commented 1 year ago

Closing in favor of #59