search

zaru / webpush

webpush, Encryption Utilities for Web Push protocol
MIT License
393 stars 73 forks source link

Fix to_pem in new Ruby versions (merge pull request) #98

Open collimarco opened 3 years ago

collimarco commented 3 years ago

The to_pem method is broken in all the new Ruby versions due to upstream changes in the OpenSSL library.

@zaru @rossta @mohamedhafez can someone please merge my pull request in order to fix the issue? It also improves test coverage for PEM.

Here's the pull request: https://github.com/zaru/webpush/pull/97

Thanks

collimarco commented 3 years ago

We have been using the new code (pull request) in production for a month and it works perfectly...

@zaru Can you please merge when you have time?