Closed EtherZa closed 5 months ago
@zarusz there appears to be an issue with the SonarCloud secret
The format of the analysis property sonar.token= is invalid
Yes, I believe secrets are not passed to branch builds which are from external repo clones. I will have a look when I get a chance.
@EtherZa I've changed the actions workflow some on master, can you please rebase your changes and push again?
@EtherZa can you please rebase against master once more and ideally squash all your changes into 1 commit? I am trying to tweak the build workflow so that SonarCloud and secrets for integration test infra are shared for PR coming from cloned repos. Unfortunately, that might require a couple of back and forth to get right.
I have looked at your changes - looks good!
@zarusz - No worries, I've rebased, squashed and pushed.
@EtherZa can you rebase once more? I've pushed some more tweaks to build workflow.
I see that sonar cloud integrates nicely already.
After that I am happy to merge.
Rebased and pushed without the unused variable.
Both SonarCloud issues resolved and pushed.
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
91.3% Coverage on New Code
0.0% Duplication on New Code
This is now merged. Thanks for your contribution @EtherZa! I will add this to the upcoming 2.3.0 release (soon).
Thank you!
Added support for optionally including IConsumerContext and/or the CancellationToken in the consumer method invocation when supplying a type and method name.
As the
CancellationToken
is tied to the life of the message lock, it should be readily available in the method to prematurely terminate processing when the lock is lost.Supplying the
IConsumerContext
as an argument, as opposed to constructor or setting injection, allows for a single consumer instance where appropriate.Please note that the order of the parameters is not important.
IConsumer and IRequestHandler have not been modified so as to avoid creating a breaking change. Implementation would be trivial should there be appetite to change the signatures.
Though not direct solutions to #220 and #223, the submission addresses both issues for non-IConsumer/IRequestHandler implementations.