Closed EtherZa closed 5 months ago
Removed some syntactic sugar that SonarCloud wasn't a fan of.
@EtherZa have a look at a few minor things.
I am also wondering if there is a way we could not require hybrid to be configured as the last (while ensuring backward compatibility with the overall serializer configuration experience).
Looks good overall!
I have added a potential option that you may prefer in the issue.
Failed conditions
C Reliability Rating on New Code (required ≥ A)
See analysis details on SonarCloud
Catch issues before they fail your Quality Gate with our IDE extension SonarLint
@EtherZa thanks for your contribution looks good!
If you have a moment would be good to tweak these 4 sonar warnings (in another PR). Else I can look at them in a few days. Cheers.
@EtherZa thanks for your contribution looks good!
Fantastic!
If you have a moment would be good to tweak these 4 sonar warnings (in another PR). Else I can look at them in a few days. Cheers.
Thanks for the support/ideas in getting it across the line.
238 PR to allow for serializers to be added and then resolved by the hybrid message serializer.
By resolving the specialized serializers from the DI container, registration of those serializers can be performed via their included builders. This will then allow for the expected dependency resolution path to be followed for each of the specialized serializers ie. JsonMessageSerializer can use a supplied JsonSerializerOptions instance or resolve one from the DI container directly
Caveat: The HybridMessageSerializer must be registered last so that it is able to remove previous IMessageSerializer registrations in order to make itself the designated serializer.