zarusz / SlimMessageBus

Lightweight message bus interface for .NET (pub/sub and request-response) with transport plugins for popular message brokers.
Apache License 2.0
467 stars 78 forks source link

[Host.Outbox.Sql] Abort publishing of unknown message types #285

Closed EtherZa closed 1 month ago

EtherZa commented 2 months ago

OutboxSendingTask will immediately abort sending a message when the MessageType fails to resolve.

Changes:

zarusz commented 1 month ago

@EtherZa 2 minor comments added.

Could you please add a note about how a missing message type will be handled to the outbox docs?

Then I am good to merge.

Thanks for your contribution.

zarusz commented 1 month ago

@EtherZa any chance you could increase the coverage on SqlOutboxRepository around the Abort methods and remove the unused variable flagged by Sonar?

EtherZa commented 1 month ago

@zarusz I have resolved the Sonar complaint and pushed the boundary again to get the requested coverage on SqlOutboxRepository by introducing TestContainers -I am assuming that you are keen to move in this direction as per your comment in 277.

Please let me know if you are happy with the approach and I will squash/sign the commit.

zarusz commented 1 month ago

@EtherZa, I appreciate you pushing this over the finish line despite project deadlines!

Yes, happy to merge. Please squash and I am going to release a minor release soon.

Thanks!

zarusz commented 1 month ago

Can you also resolve the conflict, I just merged another PR @EtherZa ?

EtherZa commented 1 month ago

@EtherZa, I appreciate you pushing this over the finish line despite project deadlines!

Yes, happy to merge. Please squash and I am going to release a minor release soon.

Thanks!

No worries. I've rebased and pushed. All should be good to go now :)

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
94.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud