Closed EtherZa closed 1 month ago
@EtherZa 2 minor comments added.
Could you please add a note about how a missing message type will be handled to the outbox docs?
Then I am good to merge.
Thanks for your contribution.
@EtherZa any chance you could increase the coverage on SqlOutboxRepository around the Abort methods and remove the unused variable flagged by Sonar?
@zarusz I have resolved the Sonar complaint and pushed the boundary again to get the requested coverage on SqlOutboxRepository
by introducing TestContainers -I am assuming that you are keen to move in this direction as per your comment in 277.
Please let me know if you are happy with the approach and I will squash/sign the commit.
@EtherZa, I appreciate you pushing this over the finish line despite project deadlines!
Yes, happy to merge. Please squash and I am going to release a minor release soon.
Thanks!
Can you also resolve the conflict, I just merged another PR @EtherZa ?
@EtherZa, I appreciate you pushing this over the finish line despite project deadlines!
Yes, happy to merge. Please squash and I am going to release a minor release soon.
Thanks!
No worries. I've rebased and pushed. All should be good to go now :)
Issues
1 New issue
0 Accepted issues
Measures
0 Security Hotspots
94.0% Coverage on New Code
0.0% Duplication on New Code
OutboxSendingTask
will immediately abort sending a message when theMessageType
fails to resolve.Changes:
MessageType
resolution moved out ofSqlOutboxRepository
and intoOutboxSendTask
andOutboxForwardingPublishInterceptor
.OutboxSendTask
fails to resolve the 'MessageType', an error is logged and the message is flagged as 'DeliveryAborted'.OutboxSendTask
fails to resolve the associated bus. The affected messages are also immediately aborted (previously, n attempts would be made before doing the same).