search

zarusz / SlimMessageBus

Lightweight message bus interface for .NET (pub/sub and request-response) with transport plugins for popular message brokers.
Apache License 2.0
467 stars 78 forks source link

[Host.Outbox] Execute permission is required for Outbox #297 #298

Closed zarusz closed 2 weeks ago

zarusz commented 2 weeks ago

Fixes #297.

zarusz commented 2 weeks ago

@EtherZa do you have a moment to review this change? It removed the need for the custom SQL type.

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

EtherZa commented 2 weeks ago

Hi @zarusz. That should work but will come with a couple caveats

  1. There is obviously more overhead with this approach and performance will be impacted but it will probably be negligable due to the numher of GUID's sent in a single update (max 50 if memory serves me).
  2. It increases the SQL compat level from 100 (SQL 2008) to 130 (SQL 2016). SQL Server 2016 is currently the earliest version with official support; so it is probably not a concern (SQL 2014 was EOL last month).
zarusz commented 2 weeks ago

Thanks for your input. The DataTable object also had some allocation footprint. The batch size is going to have some practical limitations but can't see why we'd need a huge number. Compatibility due to the used built in function is a fair point but as you said folks likely migrated.