Fix sonar warnings

[dundich]

Signed-off-by: krivchenko_kv kvkrivchenko@activebc.ru

[zarusz]

@dundich looks good. Can you please squash all your commits into one? Then I can accept the PR. Thanks for your contribution!

[dundich]

fixed: all commits in one... but he didn't pass the integration test, I don't know :(

[zarusz]

@dundich I believe the branch you want to merge from your fork does not have the recent changes needed to bring Kafka integration tests back on track (build.yaml).

From this view, your branch is 3 commits behind: https://github.com/dundich/SlimMessageBus/compare/sonar-fix...zarusz%3ASlimMessageBus%3Amaster

Please pull the latest changes from this (original) repo into your fork. Then rebase your branch aginst the latest master.

[dundich]

Thanks for the tips. Done!

[dundich]

Unused local variables should be removed ???

https://github.com/zarusz/SlimMessageBus/blob/bd33379966f710a13b5f4fc15ac084b78ab3eb08/src/SlimMessageBus.Host/DependencyResolver/ServiceCollectionExtensions.cs#L76

ps. I didn't remove it because I'm afraid of the side effect.

[sonarcloud[bot]]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
81.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[dundich]

Constructors should only call non-overridable methods

https://github.com/zarusz/SlimMessageBus/blob/bd33379966f710a13b5f4fc15ac084b78ab3eb08/src/SlimMessageBus.Host/Hybrid/HybridMessageBus.cs#L40C11-L40C12

https://rules.sonarsource.com/csharp/RSPEC-1699/

    protected virtual MessageBusBase BuildBus(MessageBusBuilder builder)

ps. Maybe - sealed class?

same warn...

public class JsonMessageSerializer : IMessageSerializer
{
    public JsonSerializerOptions Options { get; set; }

    public JsonMessageSerializer(JsonSerializerOptions options = null)
    {
        Options = options ?? CreateDefaultOptions();
    }

    public virtual JsonSerializerOptions CreateDefaultOptions()  // <==  !!??
    {

[dundich]

That's it. I'm done. :)

[zarusz]

Unused local variables should be removed ???

https://github.com/zarusz/SlimMessageBus/blob/bd33379966f710a13b5f4fc15ac084b78ab3eb08/src/SlimMessageBus.Host/DependencyResolver/ServiceCollectionExtensions.cs#L76

ps. I didn't remove it because I'm afraid of the side effect.

It should be safe to remove - I will do it.

Thanks for contribution @dundich !