zathras / jovial_svg

Flutter library for robust, efficient rendering of SVG static images

BSD 3-Clause "New" or "Revised" License

115 stars 21 forks source link

Remove unnecessary url launcher plugin from dependencies #87

Closed cheymos closed 11 months ago

cheymos commented 11 months ago

86

cheymos commented 11 months ago

@zathras Hello! What do you think about this change?

zathras commented 11 months ago

Thanks for spotting the problem. I'm not sure why you moved the Flutter SDK dependency down to 3.0; it was at 3.16 for a reason. I'd have to dig through the record to remind myself what that reason was; probably related to a Flutter platform bug that was fixed,though. Anyway, I just removed the offending dependency directly, and ran flutter upgrade in various places myself.

cheymos commented 11 months ago

Thanks for spotting the problem. I'm not sure why you moved the Flutter SDK dependency down to 3.0; it was at 3.16 for a reason. I'd have to dig through the record to remind myself what that reason was; probably related to a Flutter platform bug that was fixed,though. Anyway, I just removed the offending dependency directly, and ran flutter upgrade in various places myself.

Thanks!

cheymos commented 11 months ago

Thanks for spotting the problem. I'm not sure why you moved the Flutter SDK dependency down to 3.0; it was at 3.16 for a reason. I'd have to dig through the record to remind myself what that reason was; probably related to a Flutter platform bug that was fixed,though. Anyway, I just removed the offending dependency directly, and ran flutter upgrade in various places myself.

I didn't notice why Flutter SDK dependency is down to 3.0. I just removed the dependency using flutter pub remove. And for some reason the Flutter SDK dependency has changed.